Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TorSearchEngineProviderControllerTest.DISABLED_CheckTorProfileSearchProviderTest #1642

Closed
simonhong opened this issue Oct 17, 2018 · 2 comments · Fixed by brave/brave-core#827
Closed

Enable TorSearchEngineProviderControllerTest.DISABLED_CheckTorProfileSearchProviderTest #1642

simonhong opened this issue Oct 17, 2018 · 2 comments · Fixed by brave/brave-core#827
Assignees
@simonhong
Labels
feature/tor priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@simonhong
Copy link
Member

simonhong commented Oct 17, 2018 •
edited
Loading

When I implement TorSearchEngineProviderController, I wanted to add test case for this class whether appropriate default search engine is set.
To do this, stub test CheckTorProfileSearchProviderTest is added but crashed at initialization phase.
So, I did manually test this class and left as disabled state.
Later, anthony mentioned that TorUnittestProfileManager should be used.

brave/brave-core#529 (comment)
@simonhong simonhong self-assigned this Oct 17, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 18, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 18, 2018
@tildelowengrimm
Copy link
Contributor

Looks like this issue was just created to have something to reference in the PR? Could you add a plain-language summary of this change?

@simonhong
Copy link
Member Author

@tomlowenthal Done.

@simonhong simonhong added the QA/No label Nov 7, 2018
@simonhong simonhong mentioned this issue Nov 7, 2018
Merged
18 tasks
@simonhong simonhong modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 7, 2018
@simonhong simonhong mentioned this issue Nov 8, 2018
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/tor priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Introduce ScopedTorLaunchPreventerForTest to prevent tor process launch brave/brave-core
3 participants
@tildelowengrimm @bbondy @simonhong