Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate NTP controls from brave://settings/newTab #12505

Closed
karenkliu opened this issue Nov 3, 2020 · 2 comments · Fixed by brave/brave-core#7073
Closed

Remove duplicate NTP controls from brave://settings/newTab #12505

karenkliu opened this issue Nov 3, 2020 · 2 comments · Fixed by brave/brave-core#7073

Comments

@karenkliu
Copy link

karenkliu commented Nov 3, 2020

Description

Currently, there is a lot of overhead with having duplicate NTP controls on both Customize Dashboard in NTP and brave://settings/newTab. Also having a copy of everything in settings is unsustainable since we're going to add more options to each Customize Dashboard section over time.

Designs

brave://settings/newTab

Remove the redundant NTP controls from brave://settings, but include searchable keywords that brings the user to the NTP section. The NTP section will now re-direct users to the New Tab page with the "Customize Dashboard" panel open if they want to customize their new tab page.

image

Hide the Customize background images, sponsored... string when the New tab page shows > Homepage or Blank page option is selected, just like how it currently works:

image

Update strings in brave://settings/newTab every time our default listed widgets change.

Turn off all widgets

Include a section at the bottom of Customize Dashboard > Cards to turn off all currently visible widgets. This does not prevent users from being notified of new widgets.

image

Dark theme is supported:
image

Assets

brave://settings/newTab Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=61%3A7509
Turn off all widgets Figma: https://www.figma.com/file/0pOzvvueMoeaCxKaVoU59Z/?node-id=1880%3A22603

@rebron
Copy link
Collaborator

rebron commented Nov 3, 2020

cc: @ryanml

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 3, 2020
@ryanml ryanml self-assigned this Nov 5, 2020
@ryanml ryanml added this to the 1.19.x - Nightly milestone Nov 12, 2020
@rebron rebron changed the title [Desktop] Remove duplicate NTP controls from brave://settings/newTab Remove duplicate NTP controls from brave://settings/newTab Jan 4, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 5, 2021

Verification passed on


Brave | 1.19.73 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

  • Verified the STR from the description

  • Verified that NTP controls are removed from brave://settings/newTab
    image

  • Verified that click on the searchable keywords brings the user to the New Tab page with the "Customize Dashboard" panel
    image

  • Verified that "Customize Dashboard" and sponsored images are hidden in NTP when New tab page shows is set to Homepage or Blank page

  • Verified a section "Cards to turn off all currently visible widget" is added at the bottom of "Customize Dashboard" in NTP
    Light Theme
    image
    Dark Theme
    image

  • Verified that all the NTP widgets are hidden when "Cards to turn off all currently visible widget" is toggled off
    Light Theme
    image
    Dark Theme
    image

  • Verified that Cards toggled to ON even when one of the widgets is added to "Customize Dashboard" in NTP

  • Verified that Cards toggle state is retained after the browser restart


Verification passed on

Brave 1.19.73 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

  • Verified that NTP controls are removed from brave://settings/newTab
    image

  • Verified that click on the searchable keywords brings the user to the New Tab page with the "Customize Dashboard" panel

  • Verified that "Customize Dashboard" and sponsored images are hidden in NTP when New tab page shows is set to Homepage or Blank page

  • Verified a section "Cards to turn off all currently visible widget" is added at the bottom of "Customize Dashboard" in NTP
    Light Theme
    image
    Dark Theme
    image

  • Verified that all the NTP widgets are hidden when "Cards to turn off all currently visible widget" is toggled off
    Light Theme
    image
    Dark Theme
    image

  • Verified that Cards toggled to ON even when one of the widgets is added to "Customize Dashboard" in NTP

  • Verified that Cards toggle state is retained after the browser restart


Verified passed with

Brave	1.19.79 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
Revision	9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS	macOS Version 10.15.7 (Build 19H15)

Confirmed NTP controls are removed from brave://settings/newTab:
1

Confirmed clicking on Customize the background image and widgets that appear on the new tab page text opens NTP with "Customize Dashboard" settings modal open:
2

Confirmed Customize the background image and widgets that appear on the new tab page text is searchable:
3

Confirmed when home page is set up (Under Settings > Appearance) and New tab page shows is set to Homepage, Customize the background image and widgets that appear on the new tab page text does not show:
4

Confirmed when New tab page shows is set to Blank page, Customize the background image and widgets that appear on the new tab page text does not show:
5

Confirmed there is a section at the bottom of Customize Dashboard > Cards to turn off all currently visible widgets:

6-light

6-dark

Confirmed that all the NTP widgets are hidden when "Cards to turn off all currently visible widget" is toggled off:

7-light

7-dark

Confirmed that Cards setting gets toggled to ON even when one of the widgets is added to "Customize Dashboard" in NTP.

Confirmed that Cards toggle state is retained after the browser restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants