-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate NTP controls from brave://settings/newTab #12505
Comments
cc: @ryanml |
Verification passed on
Verification passed on
Verified passed with
Confirmed NTP controls are removed from brave://settings/newTab: Confirmed clicking on Confirmed Confirmed when home page is set up (Under Settings > Appearance) and Confirmed when Confirmed there is a section at the bottom of Customize Dashboard > Cards to turn off all currently visible widgets: Confirmed that all the NTP widgets are hidden when "Cards to turn off all currently visible widget" is toggled off: Confirmed that Cards setting gets toggled to ON even when one of the widgets is added to "Customize Dashboard" in NTP. Confirmed that Cards toggle state is retained after the browser restart. |
Description
Currently, there is a lot of overhead with having duplicate NTP controls on both Customize Dashboard in NTP and brave://settings/newTab. Also having a copy of everything in settings is unsustainable since we're going to add more options to each Customize Dashboard section over time.
Designs
brave://settings/newTab
Remove the redundant NTP controls from brave://settings, but include searchable keywords that brings the user to the NTP section. The NTP section will now re-direct users to the New Tab page with the "Customize Dashboard" panel open if they want to customize their new tab page.
Hide the
Customize background images, sponsored...
string when the New tab page shows > Homepage or Blank page option is selected, just like how it currently works:Update strings in brave://settings/newTab every time our default listed widgets change.
Turn off all widgets
Include a section at the bottom of Customize Dashboard > Cards to turn off all currently visible widgets. This does not prevent users from being notified of new widgets.
Dark theme is supported:

Assets
brave://settings/newTab Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=61%3A7509
Turn off all widgets Figma: https://www.figma.com/file/0pOzvvueMoeaCxKaVoU59Z/?node-id=1880%3A22603
The text was updated successfully, but these errors were encountered: