Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Load a remote catalog of available regional lists for brave://adblock #10830

Closed
antonok-edm opened this issue Jul 21, 2020 · 1 comment · Fixed by brave/brave-core#6125

Comments

@antonok-edm
Copy link
Collaborator

Regional lists are currently baked into the adblock-rust repository, which means they're compiled with each version of Brave. Since we ship them from our servers, it makes more sense to serve a dynamic catalog of available regional lists. This way, if a regional list is added, modified, or removed, the list shown in brave://adblock can automatically be updated to reflect the change.

This will also drastically reduce the amount of effort required to ship a filter list change, which currently requires updating/publishing several different repositories (most relevant here are adblock-rust, adblock-rust-ffi, brave-core, and brave-core-crx-packager). This change can make the update process as frictionless as a single commit to adblock-resources.

@btlechowski
Copy link

btlechowski commented Aug 21, 2020

Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6125

Verified AdGuard Français is present
image

Verified EasyList Liste FR - Version: 1.0.677 was installed
image

Verified AdGuard Français is selected after browser restart
image

Also verified Polish filters


Verification passed on

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6125

Confirmed AdGuard Français is present
Screen Shot 2020-08-21 at 9 31 19 AM

Confirmed EasyList Liste FR - Version: 1.0.677 was installed
Screen Shot 2020-08-21 at 9 32 18 AM

Confirmed AdGuard Français is still selected after browser restart

Installed 1.12.x and confirmed AdGuard Français is not present
Screen Shot 2020-08-21 at 9 30 13 AM

Confirmed it is present after upgrade to 1.13.x
Screen Shot 2020-08-21 at 9 40 37 AM


Verification passed on

Brave | 1.14.59 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment