Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [replace-across-files] Unify the Search Results Panel FindInFiles/ReplaceAll #6932

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Friday May 02, 2014 at 07:10 GMT
Originally opened as adobe/brackets#7727


@njx I just merged with master, and fixed several issues. I wasn't able to move all of the update code to the global search panel, since in this PR i just merged the display of the results and not the actual searches. We will need to move some of the search code into the results classes before we are able to move the auto update functions to the Search Results class.

Your branch is a bit behind master, so there are a few extra commits here. I guess that might not be much of a problem since this PR just mainly touches FindInFiles, and FindReplace, plus a few tempaltes and adds a new SearchResults file. But I just wanted to create a new PR.


TomMalbran included the following code: https://github.com/adobe/brackets/pull/7727/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant