[CLOSED] Refactors the search results to be able to use paging in Replace All #6392
Comments
|
Currently in Replace All, when you tick the And another cool thing would be to have an info text like |
|
|
|
Instead of doing this it might be a lot easier to implement Replace in Files as Find in Files search where in the results we include checkboxes to select what to replace and an input and button to do the replace. After that is done, Replace All, can be done as a Replace in a single File. We would still need to increase the number of results from a single file. |
|
|
|
I really like how it works now, since it lets you select what you want to replace and doesn't do it blindly. You can also see what will be replaced. |
|
I like how it works now too; I actually think it's a feature. |
|
I think one of the contributing factors to my unease is feature discoverability. I wasn't sure how to test your stuff and I thought I was just going to start blindly replacing all occurrences when I clicked the button. |
|
Replace All works in the same was as is does in master. The only difference is that this can show over 300 results and using pagination. Anyway, i don't think this is the right solution to add pagination to replace all. A better solution would be to just use find in files to do the search, and just add a replace button into that panel, when we want to also replace. That would also work with replace in files. Eventually, replace all can work as replace in files using a single file as the scope. |
|
|
|
I know how to do the UI for Replace in Files, but not sure how to handle the actual replace. |
|
If you have time to do that in the next couple days, that would be cool. I'm going to start thinking about the underlying replace-in-files functionality and maybe temporarily implementing it without the result list UI just to test it out. Once that seems to be working we could hook it up to the unified result list UI. |
|
(BTW, if you don't have time to merge master into this branch before I'm ready for it, I can do it myself.) |
|
I should have time on Thursday and Friday, or tomorrow depending on work. Go ahead and merge it, if you need it before I get to work on it. |
|
Cool, I'll let you know either way. |
Monday Mar 03, 2014 at 03:50 GMT
Originally opened as adobe/brackets#7059
I moved most of the code that handles the Search Results bottom panel display into a new SearchResults class, and I used it in FindInFiles and ReplaceAll. This made it possible to have pagination in ReplaceAll.
I included the files sorting here too, but using it in slightly different way.
TomMalbran included the following code: https://github.com/adobe/brackets/pull/7059/commits
The text was updated successfully, but these errors were encountered: