Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Mac discrete graphics card required. #4631

Open
core-ai-bot opened this issue Aug 29, 2021 · 30 comments
Open

[CLOSED] Mac discrete graphics card required. #4631

core-ai-bot opened this issue Aug 29, 2021 · 30 comments

Comments

@core-ai-bot
Copy link
Member

Issue by skoya
Tuesday Sep 03, 2013 at 07:41 GMT
Originally opened as adobe/brackets#5028

For some reason on a mac book pro retina, opening brackets causes the graphics card to switch from integrated to discrete. This drains the battery quicker when using brackets on the move. Note that chrome/safari and others do not switch graphics. Do we know why brackets does? - If there is an advanced rendering feature being used by brackets then perhaps a switch/option to disable would be greatly appreciated.
@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 16:01 GMT

@skoya do you know when this started?

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 16:21 GMT

@skoya Also, do you see this with the Chrome Canary (https://www.google.com/intl/en/chrome/browser/canary.html) build as well? I only have 10.8 on retina and gfxCardStatus has issues with 10.8 but it seems that the compositing mode used in the newer builds of Chromium may be shifting the GPU into discreet mode.

@core-ai-bot
Copy link
Member Author

Comment by skoya
Tuesday Sep 03, 2013 at 18:02 GMT

I am not sure when it started. Chrome Canary is fine: 31.0.1619.0 - it doesn't switch away from the integrated graphics card.

I am just updating canary to the latest version will report back once downloaded (on 3g at the moment).

I also have OSX 10.8.4

@core-ai-bot
Copy link
Member Author

Comment by skoya
Tuesday Sep 03, 2013 at 18:18 GMT

31.0.1620.0 doesn't switch either. Could there be something in the brackets app shell?

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Thursday Sep 12, 2013 at 16:38 GMT

Medium priority to@JeffryBooher for investigation. This may be an issue with CEF, or it could be something triggered by some of our custom CSS. We should figure out what is causing this switch.

@njx had a good suggestion -- try running Tailor (the Chrome Packaged App version of Brackets) and see if it also triggers the discreet graphics card.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Sep 14, 2013 at 06:42 GMT

We could also test the CEF theory by doing something like window.location.href = "www.google.com"; in the dev tools for Brackets, and seeing if that simpler content running in CEF also forces the discrete GPU.

@core-ai-bot
Copy link
Member Author

Comment by mseymour
Saturday Nov 16, 2013 at 05:28 GMT

I'm on 0.34.0-10729 here (Mid-2012 non-retina MBP), and it switches graphics from integrated to discrete.

It's kind of a pain when the card takes a while to switch (No idea if it has to do with the fact that I only have 4GB ram or what, though.)

@core-ai-bot
Copy link
Member Author

Comment by framerate
Tuesday Nov 19, 2013 at 16:54 GMT

This behavior is still happening, yet I noticed this bug was closed? Is this something we should look at?

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Nov 19, 2013 at 18:25 GMT

This bug is still open. (The "closed" indication above is for another issue that was a duplicate of this one.)

@core-ai-bot
Copy link
Member Author

Comment by CMRahman
Wednesday Nov 27, 2013 at 07:24 GMT

Same thing happens in Maverics as well. Is anyone looking into it?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Nov 27, 2013 at 22:00 GMT

@CMRahman You can check the assignee of any bug in the header at the top of the page. In this case it's assigned to@JeffryBooher, so that's who's looking into it.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Nov 27, 2013 at 22:40 GMT

It looks like this problem is caused by Chrome Compositing:
https://code.google.com/p/chromium/issues/detail?id=192668

I also see this
gfxstatus

Even without having any tabs open or fresh start with Chrome just showing the Google search page.

Chrome: Version 31.0.1650.57

Marking this item to Track

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Nov 27, 2013 at 23:45 GMT

@skoya@mseymour@framerate@CMRahman Can you reply back and let us know (a) what vintage Mac you're using (Apple menu > About this Mac > More Info should give something like "Mid 2009") and (b) what version of Mac OS you're running. It would also be useful if you could check whether launching Chrome itself causes the same thing to happen. Thanks!

This Chromium comment is interesting:

There are severe bugs in the graphics drivers for the mid-2010 MacBook Pro which can lead to entire system lockups when switching between the integrated and discrete GPU. For this reason Chrome forces the use of the discrete GPU on such systems.

Unclear what exactly defines "such systems" but it would be good to see what the patterns are among users who are hitting this.

@core-ai-bot
Copy link
Member Author

Comment by framerate
Thursday Nov 28, 2013 at 00:39 GMT

I'm a bit confused to your "vintage" mac comment. I have the last generation retina macbook pro.

image

OSX 10.9 Mavericks

Latest version everything.

Also, I'm running Chrome Canary right now and it is NOT triggering my discrete graphics. Although certain pages will (WebGL for example).

@core-ai-bot
Copy link
Member Author

Comment by mseymour
Thursday Nov 28, 2013 at 01:24 GMT

Mid-2012 non-retina, 10.9. Launching Chrome itself doesn’t cause the switch.

@core-ai-bot
Copy link
Member Author

Comment by CMRahman
Thursday Nov 28, 2013 at 03:25 GMT

screen shot 2013-11-28 at 9 14 55 am

OSX > 10.9 Mavericks.

I use Chrome Canary[v33] and it does't trigger discrete graphics. Regular Chrome [v31] doesn't either.
Please let me know if you need any other info.

Thanks.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Dec 06, 2013 at 19:10 GMT

I use Google Chrome and it will not let me switch to the lower powered GPU on my Macbook as shown above. @CMRahman are you using gfxCardStatus to determine that you're not running in discreet graphics mode when chrome is running? Even with a blank page -- the helper process seems to require it for me.

@core-ai-bot
Copy link
Member Author

Comment by CMRahman
Saturday Dec 07, 2013 at 18:31 GMT

@JeffryBooher - I seem to have no problem wtih Chrome as you can see from the screenshot. And yes, i'm using gfxCardStatus. I did notice that sometimes, firing up Chrome switches to discreet but then after awhile it switches back to integrated. Something that never happens with Bracket. With Bracket it always seem to run on discreet graphics.

chrome-integrated

@core-ai-bot
Copy link
Member Author

Comment by CMRahman
Saturday Dec 07, 2013 at 18:41 GMT

@JeffryBooher -- Also, if I have both Chrome and Brackets open and try to switch to integrated only, it complains about Brackets only. Screenshot attached. Thanks.

brackets-discreet

@core-ai-bot
Copy link
Member Author

Comment by daveygm
Friday Dec 13, 2013 at 08:59 GMT

I have a pull request that should fix this. It appears to just be a setting in the Info.plist file that allows the integrated GPU to be used for OpenGL and API's that rely on OpenGL.

NSSupportsAutomaticGraphicsSwitching needs to be set to true. Here is the Apple documentation for that.

By default, once your application creates an OpenGL context (by either calling OpenGL directly or an API that relies on OpenGL such as Core Animation, Core Image, etc), the MacBook Pro automatically switches to the higher-end discrete GPU for performance concerns and won't switch back until the application quits.

This can be seen in the Mavericks Activity Monitor under Energy > Requires High Perfg GPU.
after

@core-ai-bot
Copy link
Member Author

Comment by framerate
Friday Dec 13, 2013 at 17:51 GMT

Bravo Dave! Thanks for taking the time to find this!

@core-ai-bot
Copy link
Member Author

Comment by skoya
Saturday Dec 14, 2013 at 13:58 GMT

Let us know once it makes a build and I will help test it.
On 13 Dec 2013, at 17:52, Justin Reynard notifications@github.com wrote:

Bravo Dave! Thanks for taking the time to find this!

—
Reply to this email directly or view it on GitHub.

@core-ai-bot
Copy link
Member Author

Comment by daveygm
Friday Dec 20, 2013 at 00:55 GMT

Glad to help guys. The pull request was merged, so I think we will see this fix in Sprint 36.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Dec 20, 2013 at 03:00 GMT

Tagged FBNC, see adobe/brackets-shell#399

@core-ai-bot
Copy link
Member Author

Comment by CMRahman
Friday Dec 20, 2013 at 03:29 GMT

Thanks Dave.

@core-ai-bot
Copy link
Member Author

Comment by daveygm
Friday Feb 07, 2014 at 22:13 GMT

The update is now live in Sprint 36. This should now be fixed (theoretically) for dual-GPU Macbook Pros produced February 2011 and later running Mac OS X Lion and later. Please test and check back in.

@core-ai-bot
Copy link
Member Author

Comment by framerate
Friday Feb 07, 2014 at 23:16 GMT

Working great so far for me!

*- justin *|@framerate http://twitter.com/framerate | framerate.info

On Fri, Feb 7, 2014 at 2:14 PM, David Mead notifications@github.com wrote:

The update is now live in Sprint 36. This should now be fixed
(theoretically) for dual-GPU Macbook Pros produced February 2011 and later
running Mac OS X Lion and later. Please test and check back in.

Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/issues/5028#issuecomment-34512454
.

@core-ai-bot
Copy link
Member Author

Comment by njx
Saturday Feb 08, 2014 at 05:28 GMT

Closing as fixed.@skoya - if you could confirm that would be great. Thanks@daveygm!

@core-ai-bot
Copy link
Member Author

Comment by skoya
Saturday Feb 08, 2014 at 20:53 GMT

Confirmed works fine with integrated graphics card - thanks for making brackets usable on the train again!

@core-ai-bot
Copy link
Member Author

Comment by tiwuti
Wednesday Aug 12, 2015 at 19:44 GMT

@daveygm Is there a way to get this working on a Macbook pro before 2011?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot