Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [Core][Search replace panel]: The search replace panel will get truncated if the find-replace-title is too long. #4501

Open
core-ai-bot opened this issue Aug 29, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by julieyuan
Thursday Aug 22, 2013 at 03:08 GMT
Originally opened as adobe/brackets#4870


Steps:

  1. Launch Brackets and open a file.
  2. Click Edit >Replace to invoke the Replace bar on the top.
  3. Input one long string , then press Enter.
  4. Input another long string which you want to use to replace the first string, then press Enter.
  5. Click button All and observe the Search-replace-panel.

Result:
The search-replace-panel is truncated.

Expected:
UI should display well.

ENV: MAC10.8 and Win8 English OS
Build: 0.30.0-8827

Snapshot:
Please refer to snapshot for details:
capture dcran 2013-08-21 19 31 33

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Thursday Aug 22, 2013 at 04:06 GMT


Pull adobe/brackets#4661 waiting for@larz0 to review, similar solution can be then applied here.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Aug 22, 2013 at 04:26 GMT


I was thinking the same thing :)

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Thursday Aug 22, 2013 at 22:27 GMT


FBNC@julieyuan

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Monday Aug 26, 2013 at 02:12 GMT


Hi, thanks for all your efforts. I checked this issue in latest build 0.30.0-8873, the UI has changed, but I'm sorry to see this issue still happening. Here is the snapshot for reference:
capture dcran 2013-08-25 18 53 59

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Friday Sep 06, 2013 at 22:51 GMT


FBNC again.@julieyuan can you test it please?

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Tuesday Sep 10, 2013 at 07:10 GMT


Fixed in latest build 0.31.0-9351. Great job! Here is the snapshot:
screen shot 2013-09-10 at 12 06 28 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant