[CLOSED] Followup updates to #4581 and #4598

[core-ai-bot]

Issue by TomMalbran
Thursday Aug 01, 2013 at 22:10 GMT
Originally opened as adobe/brackets#4629

---

• For [CLOSED] Prompt for Live Preview Base URL is broken #4581 it now reverses the list of suits when running the before first functions, so that the before first functions from the top most suite runs first.
• For [CLOSED] Japanese text + single-byte spaces + line wrap = display and selection go wonky #4598 I improved the closing of the FILE_CLOSE_ALL dialog, reusing cancelModalDialogIfOpen.

@jasonsanjose Want to review this? No rush thought, since the changes are just minor updates.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4629/commits

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 09, 2013 at 21:16 GMT

---

Nominating sprint 30

[core-ai-bot]

Comment by jasonsanjose
Wednesday Aug 28, 2013 at 19:10 GMT

---

Moving to sprint 31

[core-ai-bot]

Comment by jasonsanjose
Tuesday Sep 03, 2013 at 22:08 GMT

---

@TomMalbran can you merge with master?

[core-ai-bot]

Comment by TomMalbran
Tuesday Sep 03, 2013 at 22:12 GMT

---

Yes I can... 1 min

[core-ai-bot]

Comment by TomMalbran
Tuesday Sep 03, 2013 at 22:26 GMT

---

@jasonsanjose Done

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 04, 2013 at 01:21 GMT

---

@TomMalbran just 2 minor comments.

[core-ai-bot]

Comment by TomMalbran
Wednesday Sep 04, 2013 at 01:38 GMT

---

@jasonsanjose Fixed.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 04, 2013 at 18:28 GMT

---

Looks good and tests are passing. Merging.