Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Hack yet another place where we need to use _codeMirror.replaceRange()... #3475

Open
core-ai-bot opened this issue Aug 29, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Friday May 03, 2013 at 17:31 GMT
Originally opened as adobe/brackets#3711


...in code hints to make them work in inline editors because of #1688. Sigh.

Fixes #3709.

To@eztierney for review. It looks like this is the single place where JS code hints actually edits the document, so I think this is the only place we have to patch this up. Let me know if there's another place we might have to do this fix.


njx included the following code: https://github.com/adobe/brackets/pull/3711/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday May 03, 2013 at 17:34 GMT


/cc@dangoor, just FYI as something to watch out for in code hint providers.@adrocknaphobia -- we should really bring the "migrate to CodeMirror doc-linking" story (https://trello.com/c/cRAl0YHB) higher on the backlog to fix this issue once and for all...

@core-ai-bot
Copy link
Member Author

Comment by eztierney
Friday May 03, 2013 at 17:59 GMT


yeah, I think this is the only place we do replaceRange.

Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant