Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fixed: Issue 3041 If you remove displayKey for Decrease Font Size shortcut, it will show up as Ctrl++ on Window #3131

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by WebsiteDeveloper
Wednesday Apr 03, 2013 at 14:13 GMT
Originally opened as adobe/brackets#3331


Fix for #3041 by mimiking a negative lookbehind.


WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3331/commits

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Apr 04, 2013 at 03:55 GMT


I think you could use regular lookahead: .replace(/-(?!$)/g, "+")

This expression seems like a closer match to what we're trying to accomplish anyway: we don't care about doubled "--"s so much as we care about "-"s that are the last char in the string (i.e. "-"s that are the keystroke rather than the delimiter).

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Thursday Apr 04, 2013 at 06:53 GMT


you are right, as the "-" we care about will always be at the end of the string this should work too.

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Thursday Apr 04, 2013 at 06:57 GMT


@peterflynn changes pushed.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Apr 16, 2013 at 21:38 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant