[CLOSED] CodeHintManager should use the new LanguageManager

[core-ai-bot]

Issue by tomsdev
Saturday Mar 09, 2013 at 20:30 GMT
Originally opened as adobe/brackets#3085

---

It would be great if CodeHintManager.registerHintProvider could take a language id provided by the new LanguageManager instead of modes in parameter. I think it's better because a language id won't change but modes can change or be added for a language.

[core-ai-bot]

Comment by njx
Monday Mar 11, 2013 at 18:40 GMT

---

Hi@tomsdev -- thanks for the suggestion. We're considering a number of API changes like this as part of our ongoing research into language extensibility on this card: https://trello.com/c/08EM5OiP -- a number of the API changes we haven't made yet are listed on this wiki page: https://github.com/adobe/brackets/wiki/Language-Support. We haven't yet prioritized the work to actually make those changes yet though--is this a blocker for your TypeScript support, or is it something that could wait until later?

[core-ai-bot]

Comment by tomsdev
Monday Mar 11, 2013 at 18:48 GMT

---

Hi@njx. It's not a blocker for the moment because the TypeScript language is not defined in Brackets but in my extension. So, I know the "modes" that it uses. But when it will be defined in Brackets it will be difficult to know the modes I have to register for in CodeHintManager. It's really simpler to just give the language id.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Apr 06, 2013 at 09:07 GMT

---

@tomsdev this should be done right now

[core-ai-bot]

Comment by tomsdev
Saturday Apr 06, 2013 at 16:44 GMT

---

Thanks, well done@WebsiteDeveloper