[CLOSED] Fixed: LanguageManager shouldn't throw exceptions

[core-ai-bot]

Issue by DennisKehrig
Monday Mar 04, 2013 at 17:21 GMT
Originally opened as adobe/brackets#3034

---

Fix for #2967

---

DennisKehrig included the following code: https://github.com/adobe/brackets/pull/3034/commits

[core-ai-bot]

Comment by jasonsanjose
Monday Mar 11, 2013 at 19:56 GMT

---

Reviewing

[core-ai-bot]

Comment by jasonsanjose
Monday Mar 11, 2013 at 20:18 GMT

---

Initial review complete

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 13, 2013 at 10:23 GMT

---

@jasonsanjose Thanks for the review! I fixed the problems you found.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 13, 2013 at 10:29 GMT

---

@jasonsanjose JSHint doesn't like my code, but JSLint does. Should we configure JSHint with "laxbreak: true" or should I update my code? Not sure how, though, I wouldn't want all this to be in one line:

    if (!language._setId(id)
            || !language._setName(name)
            || (blockComment && !language.setBlockCommentSyntax(blockComment[0], blockComment[1]))
            || (lineComment && !language.setLineCommentSyntax(lineComment))
            ) {

[core-ai-bot]

Comment by TomMalbran
Wednesday Mar 13, 2013 at 11:00 GMT

---

How about this?

if (!language._setId(id) || !language._setName(name) ||
        (blockComment && !language.setBlockCommentSyntax(blockComment[0], blockComment[1])) ||
        (lineComment && !language.setLineCommentSyntax(lineComment))) {

Looks and works in jshint.org and JSLint.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 13, 2013 at 12:32 GMT

---

@TomMalbran Looks good to me, thanks!

[core-ai-bot]

Comment by jasonsanjose
Wednesday Mar 13, 2013 at 19:35 GMT

---

Changes look good. Just need to fix the merge conflict.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 15:48 GMT

---

Supposedly the Chinese translation was changed by this... I'll try rebasing.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 15:59 GMT

---

Looking better.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 20:50 GMT

---

Purified version - no more messing with .gitattributes. Thanks@TomMalbran!

[core-ai-bot]

Comment by jasonsanjose
Tuesday Mar 19, 2013 at 22:56 GMT

---

Confirmed unit tests pass after trying a test merge with master. Merging. Thanks for your patience@DennisKehrig.