[CLOSED] Improvements to About dialog contributors list

[core-ai-bot]

Issue by njx
Friday Mar 01, 2013 at 21:56 GMT
Originally opened as adobe/brackets#3012

---

1. If the fetch of the contributors from GitHub fails, hide the spinner and show a message below like: "Lots of people (but we can't access GitHub right now to find out who)."
2. _getContributorsInformation() is no longer necessary--you can just replace it with the call to $.getJSON() (since the promise returned by that is exactly the promise you want--the extra promise that _getContributorsInformation() currently returns is redundant now, since all it does is pass through the resolve/reject from the original promise).

[core-ai-bot]

Comment by TomMalbran
Friday Mar 01, 2013 at 23:18 GMT

---

Thanks for merging it. I just added some comments to Tuckers request.

1. That looks great as a text.
2. I agree, I separate that part before mainly for the cache, but since is gone, this can be gone too.

[core-ai-bot]

Comment by njx
Friday Mar 01, 2013 at 23:56 GMT

---

Looks good, thanks for the quick fix! Closing.

[core-ai-bot]

Comment by TomMalbran
Friday Mar 01, 2013 at 23:59 GMT

---

Should this be changed to sprint 21 now?

[core-ai-bot]

Comment by njx
Saturday Mar 02, 2013 at 00:02 GMT

---

Yup, thanks.