Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update source to adhere to quote style guide. Fixes issue #1100. #1196

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by JonathanWolfe
Monday Jul 02, 2012 at 00:38 GMT
Originally opened as adobe/brackets#1211


Went through the source while I was watching a LoL stream and updated the source to follow the style guide on quotes.

I did not edit tests though.


JonathanWolfe included the following code: https://github.com/adobe/brackets/pull/1211/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 02, 2012 at 04:43 GMT


Thanks for doing this! We're actually on vacation this week so will probably pick this up next week. However, one thing I noticed was that the CodeMirror submodule SHA is showing as a diff for some reason. Could you look into this?

@core-ai-bot
Copy link
Member Author

Comment by JonathanWolfe
Monday Jul 02, 2012 at 13:38 GMT


When I cloned the repo there was that an un-pushed commit already there, I must have included it in mine.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Jul 09, 2012 at 17:50 GMT


Jonathan, you'll need to sign the Contributor's License Agreement: http://dev.brackets.io/brackets-contributor-license-agreement.html

@core-ai-bot
Copy link
Member Author

Comment by JonathanWolfe
Monday Jul 09, 2012 at 18:06 GMT


I also signed the agreement.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Jul 09, 2012 at 19:46 GMT


Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant