[CLOSED] Add 'onHighlight' optional event callback mechanism for better extensibility features in hint providers

[core-ai-bot]

Issue by swmitra
Thursday Mar 01, 2018 at 17:20 GMT
Originally opened as adobe/brackets#14140

---

This PR is targeted to add an optional onHighlight hook handling for Code hint providers. This will help extension developers to add interactive workflows when a user crawls over hint items in hint popup.

@nethip@petetnt All yours now, please have a look at the change set.

---

swmitra included the following code: https://github.com/adobe/brackets/pull/14140/commits

[core-ai-bot]

Comment by swmitra
Sunday Mar 04, 2018 at 06:48 GMT

---

Thanks a lot@petetnt for quick review :+1.

This would be a provider specific implementation. IMHO, scoping the event emitter to a provider will make the listener code ambiguous. Also, keeping this as a hook keeps the reach of the handling very shallow and declaration of the intent is upfront. But that's my thought, want to hear the advantages of event emitter in this case as well.

[core-ai-bot]

Comment by nethip
Tuesday Mar 06, 2018 at 10:47 GMT

---

@swmitra LGTM. But +1 on@petetnt comment about documentation.

[core-ai-bot]

Comment by petetnt
Tuesday Mar 06, 2018 at 10:52 GMT

---

FWIW I am okay with this not being an event emitter too as code hint list providers provide functions anyway now that I looked at this more 👍

[core-ai-bot]

Comment by swmitra
Wednesday Mar 28, 2018 at 09:53 GMT

---

@nethip@petetnt Added this to our wiki for code hint API's.
https://github.com/adobe/brackets/wiki/New-Code-Hinting-API-Proposal

[core-ai-bot]

Comment by nethip
Wednesday Mar 28, 2018 at 09:56 GMT

---

Thanks@swmitra

[core-ai-bot]

Comment by swmitra
Wednesday Mar 28, 2018 at 09:57 GMT

---

Thanks@nethip 😃