Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] do nothing when trying to reset with the same content which is already present #10810

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by zaggino
Tuesday Aug 16, 2016 at 14:41 GMT
Originally opened as adobe/brackets#12681


I've encountered a case of adobe/brackets#11826 and this fixes it (don't necessarily fix all possible cases but it is at least something)

cc@nethip@petetnt


zaggino included the following code: https://github.com/adobe/brackets/pull/12681/commits

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Tuesday Aug 16, 2016 at 15:01 GMT


@zaggino it would be awesome if you can add a test case.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Tuesday Aug 16, 2016 at 17:41 GMT


Most likely fixes things like brackets-userland/brackets-git#1274 to some extent. Looks good to me.

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Wednesday Aug 17, 2016 at 00:17 GMT


@ficristo test added, i've tested that it fails before and passes after the fix too

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday Aug 17, 2016 at 04:44 GMT


Nice fix@zaggino . LGTM.

Note: I am going ahead with the merge. Travis is failing because of the API limit issues.

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday Aug 17, 2016 at 04:44 GMT


Thanks@zaggino

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Wednesday Aug 17, 2016 at 06:11 GMT


test added

@zaggino great job, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant