[CLOSED] Possible fix for #1473 (Uninstaller doesn't always remove Brackets start menu shortcut)

[core-ai-bot]

Issue by peterflynn
Friday Oct 26, 2012 at 00:01 GMT
Originally opened as adobe#136

---

Possible fix for bug adobe/brackets#1473: use a different GUID for StartMenuShortcut from previous sprints, which should disentangle the Component ref counts and allow uninstalling the two shortcuts independently.

This fix was suggested by @RajNarayana, and I've found some other small references to this as well. I did a brief test and it appears to fix the problem on the build machine when there are side-by-side installs.

I don't think we should actually close 1473 right away, though -- given how inconsistently reproducible it's been, we should wait until Sprint 16 ends and we can verify this more broadly on various different computers. At that point we can also consider whether to automate the GUID changing or just add it to the sprint checklist.

---

peterflynn included the following code: https://github.com/adobe/brackets-shell/pull/136/commits

[core-ai-bot]

Comment by gruehle
Friday Oct 26, 2012 at 00:46 GMT

---

Let's give it a shot. Merging.