[CLOSED] use g_spawn_command_line_async instead of execlp

[core-ai-bot]

Issue by jasonsanjose
Tuesday Sep 03, 2013 at 17:27 GMT
Originally opened as adobe#319

---

@macie After merging #317 I noticed in the execlp and execl docs http://linux.die.net/man/3/execlp...

The exec() family of functions replaces the current process image with a new process image

This didn't seem right to replace the brackets process with the browser. To avoid this, I moved to g_spawn_command_line_async https://developer.gnome.org/glib/2.34/glib-Spawning-Processes.html#g-spawn-command-line-async.

While cleaning that up, I also...

• Changed CloseLiveBrowser to also kill the same set of browsers google-chrome, chromium, and chromium-browser
• Fixed ShowFolderInOSWindow to use file: uris
• Use g_get_user_config_dir instead of $HOME to get the correct config folder, see Follow XDG Base Directory Specification adobe/brackets#4932

---

jasonsanjose included the following code: https://github.com/adobe/brackets-shell/pull/319/commits

[core-ai-bot]

Comment by pthiess
Wednesday Sep 04, 2013 at 17:12 GMT

---

@ingorichter Hey Ingo, please take a look .

[core-ai-bot]

Comment by jasonsanjose
Thursday Sep 05, 2013 at 18:35 GMT

---

@ingorichter pushed changes. Ready to review.

[core-ai-bot]

Comment by jasonsanjose
Monday Sep 09, 2013 at 18:17 GMT

---

Also fixes #4909

[core-ai-bot]

Comment by jasonsanjose
Monday Sep 09, 2013 at 18:17 GMT

---

Also fixes adobe/brackets#4909