From 656f801c22d2c0d30df0b1c1ef4f80ebbf3b880d Mon Sep 17 00:00:00 2001
From: Niklas Kiefer <niklas.kiefer@camunda.com>
Date: Fri, 21 Jan 2022 08:55:36 +0100
Subject: [PATCH] fix(element-templates): do not render empty descriptions

---
 .../components/PropertyDescription.js               |  2 +-
 .../properties/CustomProperties.description.json    | 10 +++++++++-
 .../properties/CustomProperties.spec.js             | 13 +++++++++++++
 3 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/src/provider/element-templates/components/PropertyDescription.js b/src/provider/element-templates/components/PropertyDescription.js
index ada914ee2..f136d2c6e 100644
--- a/src/provider/element-templates/components/PropertyDescription.js
+++ b/src/provider/element-templates/components/PropertyDescription.js
@@ -8,7 +8,7 @@ export function PropertyDescription(props) {
     description
   } = props;
 
-  return (
+  return description && (
     <Markup
       markup={ sanitizeHTML(description) }
       trim={ false } />
diff --git a/test/spec/provider/element-templates/properties/CustomProperties.description.json b/test/spec/provider/element-templates/properties/CustomProperties.description.json
index d053a935f..b2f74048b 100644
--- a/test/spec/provider/element-templates/properties/CustomProperties.description.json
+++ b/test/spec/provider/element-templates/properties/CustomProperties.description.json
@@ -67,13 +67,21 @@
         }
       },
       {
-        "label": "string",
+        "label": "withHTML",
         "description": "By the way, you can use <a target='_blank' href=\"https://freemarker.apache.org/\">freemarker templates</a> here",
         "type": "String",
         "binding": {
           "type": "property",
           "name": "string"
         }
+      },
+      {
+        "label": "empty",
+        "type": "String",
+        "binding": {
+          "type": "property",
+          "name": "string"
+        }
       }
     ]
   }
diff --git a/test/spec/provider/element-templates/properties/CustomProperties.spec.js b/test/spec/provider/element-templates/properties/CustomProperties.spec.js
index 193f6b62c..71b64940b 100644
--- a/test/spec/provider/element-templates/properties/CustomProperties.spec.js
+++ b/test/spec/provider/element-templates/properties/CustomProperties.spec.js
@@ -1392,6 +1392,19 @@ describe('provider/element-templates - CustomProperties', function() {
         '</div>'
       );
     });
+
+
+    it('should NOT display empty descriptions', async function() {
+
+      // when
+      await expectSelected('Task');
+
+      // then
+      const entry = findEntry('custom-entry-com.camunda.example.description-5', container);
+      const description = domQuery('.bio-properties-panel-description', entry);
+
+      expect(description).to.not.exist;
+    });
   });