You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unlike when installing a dependency with Composer, no constraint check is done when installing/using a PHAR. It can be done in an installer but then it's easy to miss it if downloading the PHAR directly, keeping the PHAR around and updating it or copying it from somewhere.
It is limited to checking extensions and the PHP platform (which can be fine) but don't take into consideration polyfills. A possible solution could be to look if a polyfill is included as well and ignore the extension requirement if it is
As of now it only checks the project composer.json and don't account for the dependencies composer.json files which is silly
There is a lot of boilertemplate due to the fact that it may run on unsupported PHP version. In the case of PHP-Scoper for example, that part is compatible with PHP 5.6 even though the project requires PHP7.1 to be able to provide a nice error message when running on PHP 5.6 instead of crashing with a weird error (which is the whole point of that checker except it's not limited to PHP versions). I however didn't check much more if it could be made more re-usable or something so to be investigated to try to make it simpler.
Edit: Composer 1.6.0 added a check-platform-reqs, I think it's worth checking it out
The text was updated successfully, but these errors were encountered:
Unlike when installing a dependency with Composer, no constraint check is done when installing/using a PHAR. It can be done in an installer but then it's easy to miss it if downloading the PHAR directly, keeping the PHAR around and updating it or copying it from somewhere.
An attempt has been made in PHP-Scoper: link based on Symfony's requirement checker. It however has a few drawbacks:
composer.json
and don't account for the dependenciescomposer.json
files which is sillyEdit: Composer 1.6.0 added a
check-platform-reqs
, I think it's worth checking it outThe text was updated successfully, but these errors were encountered: