Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error location #18

Open
bovee opened this issue Mar 6, 2022 · 0 comments
Open

Fix error location #18

bovee opened this issue Mar 6, 2022 · 0 comments

Comments

@bovee
Copy link
Owner

bovee commented Mar 6, 2022

With the big v0.3 rewrite I changed how the parser advances so the EtErrorContext::byte in most error messages is no longer pointing to the correct position in the record, but rather to the first byte.

I think the best fix for this is to manually set byte (maybe in EtError::new?) when the error is created and to make sure that the calling next function doesn't overwrite this when it's handling the error, but this involves updating every EtError constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant