Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload_fileobj does not look up previously uploaded parts #1669

Closed
dariusjs opened this issue Aug 21, 2018 · 2 comments
Closed

upload_fileobj does not look up previously uploaded parts #1669

dariusjs opened this issue Aug 21, 2018 · 2 comments

Comments

@dariusjs
Copy link

dariusjs commented Aug 21, 2018

This is probably an edge case. Initially I tried using the upload_fileobj method within an AWS Lambda function. Some of the downloads I need to perform take longer than the maximum lambda timeout so it ends prematurely. On a next lambda run it ends up creating a new UploadID as evidenced by running the list_parts method.

I have ended up building my own download manager using the available API's that can resume downloads but perhaps it would be worthwhile having the upload_fileobj support this.

Something like this potentially should not sit in a lambda but I would like to see if any others run into this.

@joguSD
Copy link
Contributor

joguSD commented Aug 31, 2018

I'm not sure if we would be able to support something like this without making grossly unsafe assumptions about the contents being uploaded. Specifically, we have no way of ensuring that the provided file is going to be the same between two upload_fileobj calls. Does the code you wrote account for this or does it just assume that the contents are the same?

@joguSD joguSD added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 31, 2018
@dariusjs
Copy link
Author

dariusjs commented Sep 1, 2018

No I don’t. I am using dynamodb to check against an md5sum of the file. As I mentioned something like this most likely does not belong in a lambda.

@no-response no-response bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 1, 2018
@dariusjs dariusjs closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants