From 0ec8b617b8a82729e43db9777cf32da244d01f8d Mon Sep 17 00:00:00 2001 From: Akshay Krishnan Date: Tue, 25 Oct 2022 23:28:01 -0400 Subject: [PATCH 1/3] fix wrapper argument --- gtsam/sfm/sfm.i | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gtsam/sfm/sfm.i b/gtsam/sfm/sfm.i index 26dc20c3ef..922ba9efc5 100644 --- a/gtsam/sfm/sfm.i +++ b/gtsam/sfm/sfm.i @@ -329,7 +329,7 @@ class MatchIndicesMap { size_t size() const; bool empty() const; void clear(); - gtsam::gtsfm::CorrespondenceIndices at(const pair& keypair) const; + gtsam::gtsfm::CorrespondenceIndices at(const IndexPair& keypair) const; }; class Keypoints { @@ -350,6 +350,7 @@ class KeypointsVector { gtsam::SfmTrack2dVector tracksFromPairwiseMatches( const gtsam::gtsfm::MatchIndicesMap& matches_dict, const gtsam::gtsfm::KeypointsVector& keypoints_list, bool verbose = false); + } // namespace gtsfm } // namespace gtsam From b0533bb1984956ded7ca24bcafc3bcc204adc04e Mon Sep 17 00:00:00 2001 From: Akshay Krishnan Date: Tue, 25 Oct 2022 23:50:47 -0400 Subject: [PATCH 2/3] add gtsam:: prefix --- gtsam/sfm/sfm.i | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/sfm/sfm.i b/gtsam/sfm/sfm.i index 922ba9efc5..c57e03174f 100644 --- a/gtsam/sfm/sfm.i +++ b/gtsam/sfm/sfm.i @@ -329,7 +329,7 @@ class MatchIndicesMap { size_t size() const; bool empty() const; void clear(); - gtsam::gtsfm::CorrespondenceIndices at(const IndexPair& keypair) const; + gtsam::gtsfm::CorrespondenceIndices at(const gtsam::IndexPair& keypair) const; }; class Keypoints { From 3da27a5df7714338ef7a6790413ade12128a8ade Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Wed, 26 Oct 2022 12:42:45 -0400 Subject: [PATCH 3/3] add docstring to test and fix assert --- python/gtsam/tests/test_DsfTrackGenerator.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python/gtsam/tests/test_DsfTrackGenerator.py b/python/gtsam/tests/test_DsfTrackGenerator.py index e600227c9f..284c3f5ccf 100644 --- a/python/gtsam/tests/test_DsfTrackGenerator.py +++ b/python/gtsam/tests/test_DsfTrackGenerator.py @@ -7,7 +7,8 @@ import gtsam import numpy as np -from gtsam import IndexPair, KeypointsVector, MatchIndicesMap, Point2, SfmMeasurementVector, SfmTrack2d +from gtsam import (IndexPair, KeypointsVector, MatchIndicesMap, Point2, + SfmMeasurementVector, SfmTrack2d) from gtsam.gtsfm import Keypoints from gtsam.utils.test_case import GtsamTestCase @@ -84,12 +85,12 @@ class TestSfmTrack2d(GtsamTestCase): """Tests for SfmTrack2d.""" def test_sfm_track_2d_constructor(self) -> None: - """ """ + """Test construction of 2D SfM track.""" measurements = SfmMeasurementVector() measurements.append((0, Point2(10, 20))) track = SfmTrack2d(measurements=measurements) track.measurement(0) - track.numberMeasurements() == 1 + assert track.numberMeasurements() == 1 if __name__ == "__main__":