Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Values types #958

Closed
varunagrawal opened this issue Dec 10, 2021 · 0 comments
Closed

Unify Values types #958

varunagrawal opened this issue Dec 10, 2021 · 0 comments
Assignees
Labels
feature New proposed feature

Comments

@varunagrawal
Copy link
Collaborator

Feature

Currently discrete factor types require the use of custom Values which is just an alias to the Assignment class. We can achieve the same objective using the regular gtsam::Values.

We should remove all the Values typedefs in discrete/ and instead use good ol' gtsam::Values.

Motivation

This unification will help with the newly proposed HybridFactors. Tagging @dellaert for visibility.

Pitch

Update all the code to use gtsam::Values and the tests should all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New proposed feature
Projects
None yet
Development

No branches or pull requests

1 participant