Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation] Properly mark deprecated functions in C++ #889

Closed
ProfFan opened this issue Oct 10, 2021 · 2 comments · Fixed by #925
Closed

[Deprecation] Properly mark deprecated functions in C++ #889

ProfFan opened this issue Oct 10, 2021 · 2 comments · Fixed by #925
Assignees
@ProfFan

Comments

@ProfFan
Copy link
Collaborator

ProfFan commented Oct 10, 2021

We should mark deprecated functions both in Doxygen and in C++.

For example,

In EliminateableFactorGraph-inst.h Line 39 it's calling deprecated function.
@ProfFan ProfFan self-assigned this Oct 10, 2021
This was referenced Nov 10, 2021
Merged
Merged
@dellaert
Copy link
Member

I think this was incorrectly closed

@dellaert dellaert reopened this Nov 12, 2021
@varunagrawal
Copy link
Collaborator

What is needed to close this? PR #925 added the macros for conditonal compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProfFan ProfFan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proper Deprecation of Eliminate Methods borglab/gtsam
3 participants
@varunagrawal @ProfFan @dellaert