Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch between calibrate functions for Cal3_S2 and Cal3DS2 #621

Closed
varunagrawal opened this issue Nov 30, 2020 · 0 comments · Fixed by #623
Closed

Mismatch between calibrate functions for Cal3_S2 and Cal3DS2 #621

varunagrawal opened this issue Nov 30, 2020 · 0 comments · Fixed by #623
Assignees
@varunagrawal
Labels
bugfix Fixes an issue or bug

Comments

@varunagrawal
Copy link
Collaborator

Description

This is the same issue as #237 but for Cal3DS2. We need to use the Implicit Function theorem to fix this in Cal3DS2_Base.cpp.
@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Nov 30, 2020
@varunagrawal varunagrawal self-assigned this Nov 30, 2020
This was referenced Nov 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jacobians for Camera models borglab/gtsam
1 participant
@varunagrawal