Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled borg info invalidates cache, causing expensive sync on next operation #8330

Closed
rrueger opened this issue Aug 9, 2024 · 4 comments · Fixed by #8332
Closed

Cancelled borg info invalidates cache, causing expensive sync on next operation #8330

rrueger opened this issue Aug 9, 2024 · 4 comments · Fixed by #8332
Labels

Comments

@rrueger
Copy link

rrueger commented Aug 9, 2024

Have you checked borgbackup docs, FAQ, and open GitHub issues? Yes

Is this a BUG / ISSUE report or a QUESTION? Question

Borg Version borg 1.1.15

Operating system (distribution) and version. Ubuntu 20.04

Hardware / network configuration, and filesystems used. Btrfs

How much data is handled by borg? 750PB (15000 Snapshots of 50GB, 120GB Deduplicated)

Everything is on the same host and disk (a directory is backed up to a borg repository on the same device, no other devices accessing the same repo)

Describe the problem you're observing.

Cancelling (Ctrl-C'ing) a borg info command apparently invalidates the chunks cache, causing an expensive re-build on the next operation (e.g. create)

I don't know what happens under the hood, but borg info feels like it should be a read-only operation, and therefore should not be able to invalidate the cache.

Is this a bug, or expected behaviour?

I cancelled the borg info call because it was taking a long-ish time (~15 minutes)

Many thanks!

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Aug 9, 2024

If you mean "archives in one repository" when saying snapshots, you should reduce that count to get better speed. Some operations are O(archive count), thus 15000 will make it 100x slower than 150.

You are using a rather old borg version and there were many fixes and improvements since then, maybe upgrade to the latest one in maintainer's ppa. Maybe that bug was fixed in a later version.

Important: read the changelog when upgrading, esp. about:

  • borg compact (>= 1.2.0)
  • the CVE-related upgrade procedure (>= 1.2.5).

Ubuntu 22.04 would also come with a more recent borg version (but even 1.2.0 is old meanwhile, so the ppa hint also applies to that).

Ubuntu 24.04 has borg 1.2.8.

The PPA has 1.4.0:

https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/borgbackup?field.series_filter=noble

@rrueger
Copy link
Author

rrueger commented Aug 9, 2024

I understand. I will be changing to an OS with Borg version 1.4 soon

I will perform the following upgrade path as outlined in the Upgrade Notes

  • Upgrade to newest 1.1.x version (1.1.18)
  • Upgrade to newest 1.2.x version (1.2.7)
  • Upgrade to newest 1.4.x version (1.4.0)

Can I upgrade directly from 1.1.18 to 1.2.7 without the intermediate step of 1.2.5/1.2.6?

@ThomasWaldmann
Copy link
Member

@rrueger sorry for late answer.

Yes, you can directly go from 1.1.18 to 1.2.7/1.2.8 or even 1.4.x, but follow the upgrade steps detailed in the changelog.

@rrueger
Copy link
Author

rrueger commented Aug 30, 2024

No worries!

Thank you very much

@rrueger rrueger closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants