Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle symbols in .cljs.edn files #148

Closed
arichiardi opened this issue Jan 3, 2017 · 1 comment
Closed

Gracefully handle symbols in .cljs.edn files #148

arichiardi opened this issue Jan 3, 2017 · 1 comment
Milestone

Comments

@arichiardi
Copy link
Contributor

arichiardi commented Jan 3, 2017

At the moment, an exception is thrown when I use:

{:require [rest-resource-viz.core]
 :on-jsload 'rest-resource-viz.core/on-jsload} ;; with apex

Instead of the correct:

{:require [rest-resource-viz.core]
 :on-jsload rest-resource-viz.core/on-jsload}

It would be great to walk the edn file and warn instead. I know this opens the door to a bigger problem, that is how to validate .cljs.edn files but ... well... at some point maybe we need it.

Thanks for moving it to the new org @Deraen!

@Deraen
Copy link
Contributor

Deraen commented Apr 12, 2017

Done in fbf5297

Boot-reload should do the same for :on-jsload option: adzerk-oss/boot-reload#116

@Deraen Deraen closed this as completed Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants