Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded language ISO in instance info #2830

Closed
jaschaurbach opened this issue Apr 16, 2023 · 1 comment · Fixed by #2832
Closed

Hardcoded language ISO in instance info #2830

jaschaurbach opened this issue Apr 16, 2023 · 1 comment · Fixed by #2832
Labels
activitypub bug Something isn't working

Comments

@jaschaurbach
Copy link
Member

This line of code

bookwyrm/bookwyrm/views/wellknown.py

Line 113 in 290b740

"languages": ["en"],

needs to be changed that the actual language of the instance is shown. My instance is set to German but it tells the world that it is in English.

The problem I have here (and why I just not solved it right now) is that the language is represented by a ISO 639-1 two-letter code and I do not see that we have it here. The question is: Do we need 4 letter codes in .env/settings.pyor can we somehow derive from this setting and get the two letter code?

Anyhow, I am too confused to do it atm.
@jaschaurbach jaschaurbach added bug Something isn't working activitypub labels Apr 16, 2023
@jaschaurbach jaschaurbach mentioned this issue Apr 16, 2023
Merged
@jaschaurbach
Copy link
Member Author

Never mind, found a simple and easy solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
activitypub bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix language constant to show correct lang in API bookwyrm-social/bookwyrm
1 participant
@jaschaurbach