Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Links Are Confusing Because Font Colors Appear Reversed #2697

Closed
varanasib opened this issue Feb 26, 2023 · 4 comments
Closed

Feed Links Are Confusing Because Font Colors Appear Reversed #2697

varanasib opened this issue Feb 26, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers UI

Comments

@varanasib
Copy link

Describe the bug
When viewing a feed page, there are two "tabs." The current feed, the one being viewed, has blue words (elsewhere in BookWyrm and generally on the web) indicating a clickable link. The link to the other feed is in black which is typically not a clickable link. The color of the tabs is reversed

To Reproduce
Steps to reproduce the behavior:

  1. Go to Feeds page
  2. Click on black "tab"
  3. The other feed page loads

Expected behavior
Clicking on blue words should open a new link. Clicking on black words should stay on same page.

Instance
ramblingreaders.org

Additional context
The URLS for the tabs go to an anchor link on the same page, to the very top of the feed. This anchor is immediately below the feed selection tabs, so on almost any screen, the anchor link is not useful.


Desktop (please complete the following information):
-- Chrome for Linux Version 110.0.5481.177 (Official Build) (64-bit)

@varanasib varanasib added the bug Something isn't working label Feb 26, 2023
@mouse-reeve mouse-reeve added the UI label Feb 27, 2023
@hughrun hughrun added the good first issue Good for newcomers label Feb 27, 2023
@varanasib
Copy link
Author

varanasib commented Feb 27, 2023

This same problem exists with the tabs on the status posting page.

@varanasib
Copy link
Author

Is this just a matter of switching these colors around?

`/* links */
$link: #3273dc;
$link-background: $link;
$link-hover: $grey-darker;
$link-focus: $grey-darker;
$link-active: $grey-darker;`

https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/static/css/themes/bookwyrm-light.scss

@varanasib
Copy link
Author

Well, apparently I am wrong about the link colors being relatively standard. Here's google translate using blue to show the language one has chosen. There's an additional underscore, but . . . .
Untitled

@rkmdCodes
Copy link
Contributor

hi @mouse-reeve @hughrun @varanasib
I have added some CSS to interchange the color in the PR #2698 .

@hughrun hughrun closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

4 participants