From 912e92bacd462590dc6954723324395120d14d67 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Sun, 7 May 2023 09:50:24 -0700 Subject: [PATCH 1/2] Show all (not just open) reports when linked from user admin --- bookwyrm/templates/settings/reports/reports.html | 4 ++-- bookwyrm/templates/settings/users/user_info.html | 2 +- bookwyrm/views/admin/reports.py | 10 ++++++++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/bookwyrm/templates/settings/reports/reports.html b/bookwyrm/templates/settings/reports/reports.html index 64db2f26b8..f48314c8a8 100644 --- a/bookwyrm/templates/settings/reports/reports.html +++ b/bookwyrm/templates/settings/reports/reports.html @@ -21,10 +21,10 @@ {% block panel %}
diff --git a/bookwyrm/templates/settings/users/user_info.html b/bookwyrm/templates/settings/users/user_info.html index a04db3b8ee..a1725ae36c 100644 --- a/bookwyrm/templates/settings/users/user_info.html +++ b/bookwyrm/templates/settings/users/user_info.html @@ -61,7 +61,7 @@

{% trans "User details" %}

{{ report_count|intcomma }} {% if report_count > 0 %} - + {% trans "(View reports)" %} {% endif %} diff --git a/bookwyrm/views/admin/reports.py b/bookwyrm/views/admin/reports.py index 480f926a48..9590db0da4 100644 --- a/bookwyrm/views/admin/reports.py +++ b/bookwyrm/views/admin/reports.py @@ -29,14 +29,20 @@ def get(self, request): """view current reports""" filters = {} - resolved = request.GET.get("resolved") == "true" + # we sometimes want to see all reports, regardless of resolution + if request.GET.get("resolved") == "all": + resolved = "all" + else: + resolved = request.GET.get("resolved") == "true" + server = request.GET.get("server") if server: filters["user__federated_server__server_name"] = server username = request.GET.get("username") if username: filters["user__username__icontains"] = username - filters["resolved"] = resolved + if resolved != "all": + filters["resolved"] = resolved reports = models.Report.objects.filter(**filters) paginated = Paginator(reports, PAGE_LENGTH) From 0e0d9d2d083414854120a3efbeafc6123956fb39 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Mon, 15 May 2023 05:31:07 -0700 Subject: [PATCH 2/2] Updates ignore html error list --- bookwyrm/tests/validate_html.py | 1 + 1 file changed, 1 insertion(+) diff --git a/bookwyrm/tests/validate_html.py b/bookwyrm/tests/validate_html.py index e98a4f3f82..423a86586b 100644 --- a/bookwyrm/tests/validate_html.py +++ b/bookwyrm/tests/validate_html.py @@ -18,6 +18,7 @@ def validate_html(html): for e in errors.split("\n") if "&book" not in e and "&type" not in e + and "&resolved" not in e and "id and name attribute" not in e and "illegal characters found in URI" not in e and "escaping malformed URI reference" not in e