From 2352ffbf76c236a5b8a7a00f9a9d9abf3f8a8f93 Mon Sep 17 00:00:00 2001 From: Markus Notti Date: Wed, 16 Mar 2022 15:02:09 -0700 Subject: [PATCH 1/2] fix lb strategy logging error --- cmd/ghz/main.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/ghz/main.go b/cmd/ghz/main.go index 918825ad..cf49c51d 100644 --- a/cmd/ghz/main.go +++ b/cmd/ghz/main.go @@ -315,8 +315,8 @@ func main() { options = append(options, runner.WithLogger(logger)) } - if isLBStrategySet && cfg.Host != "" && !strings.HasPrefix(cfg.Host, "dns:///") { - logger.Warn("Load balancing strategy set without using DNS (dns:///) scheme. ", "Strategy: ", cfg.LBStrategy, " Host: ", cfg.Host) + if logger != nil && isLBStrategySet && cfg.Host != "" && !strings.HasPrefix(cfg.Host, "dns:///") { + logger.Warnw("Load balancing strategy set without using DNS (dns:///) scheme. ", "strategy", cfg.LBStrategy, "host", cfg.Host) } if logger != nil { From 4db2f0ea8f40d66205656aef7564c5ac83dd6f09 Mon Sep 17 00:00:00 2001 From: Markus Notti Date: Wed, 16 Mar 2022 15:10:45 -0700 Subject: [PATCH 2/2] cleaning log line --- cmd/ghz/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ghz/main.go b/cmd/ghz/main.go index cf49c51d..be418dc8 100644 --- a/cmd/ghz/main.go +++ b/cmd/ghz/main.go @@ -316,7 +316,7 @@ func main() { } if logger != nil && isLBStrategySet && cfg.Host != "" && !strings.HasPrefix(cfg.Host, "dns:///") { - logger.Warnw("Load balancing strategy set without using DNS (dns:///) scheme. ", "strategy", cfg.LBStrategy, "host", cfg.Host) + logger.Warnw("Load balancing strategy set without using DNS (dns:///) scheme", "strategy", cfg.LBStrategy, "host", cfg.Host) } if logger != nil {