From 297df44ceb5f4e41eff70955845067ab9d011147 Mon Sep 17 00:00:00 2001 From: aidencao Date: Mon, 30 Oct 2023 10:37:09 +0800 Subject: [PATCH 1/2] fix: Replace legacy method --- packages/js-sdk/src/clients/spclient/sign.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/js-sdk/src/clients/spclient/sign.ts b/packages/js-sdk/src/clients/spclient/sign.ts index 6bc7439c..8bd19fe3 100644 --- a/packages/js-sdk/src/clients/spclient/sign.ts +++ b/packages/js-sdk/src/clients/spclient/sign.ts @@ -22,12 +22,10 @@ const signMessagePersonalAPI = async ( message: Uint8Array, address: string, ): Promise => { - return provider.send('personal_sign', [hexlify(message), address]).then( - (sign: string) => sign, - (err: Error) => { - throw err; - }, - ); + return provider.request({ + method: 'personal_sign', + params: [hexlify(message), address], + }); }; const generateSeed = async ( @@ -36,7 +34,7 @@ const generateSeed = async ( ) => { const signedBytes = typeof message === 'string' ? toUtf8Bytes(message) : arrayify(message); const res = (await signMessagePersonalAPI(provider, signedBytes, address)) as any; - const seed = arrayify(res?.result); + const seed = arrayify(res); return { seed }; }; From 31fc2e6061ce25cdf3e0571ec199d49c5422d92c Mon Sep 17 00:00:00 2001 From: rrr523 <59029880+rrr523@users.noreply.github.com> Date: Mon, 30 Oct 2023 11:07:48 +0800 Subject: [PATCH 2/2] Create cool-shoes-visit.md --- .changeset/cool-shoes-visit.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cool-shoes-visit.md diff --git a/.changeset/cool-shoes-visit.md b/.changeset/cool-shoes-visit.md new file mode 100644 index 00000000..a606eac7 --- /dev/null +++ b/.changeset/cool-shoes-visit.md @@ -0,0 +1,5 @@ +--- +"@bnb-chain/greenfield-js-sdk": patch +--- + +fix: Replace legacy method, Some third-party plug-ins (e.g. wallet guard) will automatically convert deprecated methods and are not compatible with the return value of deprecated methods. https://github.com/wallet-guard/wallet-guard-extension/blob/221ad3eb329ad7681b16a37c7ddfaf173dba6e7f/src/injected/injectWalletGuard.tsx#L49-L62