Fix assert #179
Fix assert #179
Conversation
| @@ -218,29 +218,29 @@ def main(): | |||
|
|
|||
| for item in report.items.values(): | |||
| if isinstance(item.location, File_Reference): | |||
| assert os.path.isdir(item.location.filename) or \ | |||
There was a problem hiding this comment.
I don't understand this fix.
The idea is the following:
If item.location is of type File_Reference, then it must be a directory or a file (i.e. not a symlink).
And afterwards the rest of the code can be executed.
Which issue is being fixed by removing this assertion?
| @@ -161,15 +161,15 @@ def main(): | |||
| tag = Tracing_Tag("cpp", function_uid) | |||
| loc = File_Reference(filename, line_nr) | |||
|
|
|||
| assert tag.key() not in db | |||
There was a problem hiding this comment.
Here the idea of the assertion is to ensure that db[tag.key()] will not be overwritten. If it already exists in db, then that duplicate definition must be detected. We could raise a better user-friendly error message of course.
There was a problem hiding this comment.
In case there is a duplicate definition, lobster-cpp will crash, and the idea is just to go next without doing anything in this particular case by just using an "if" statement instead of "assert".
Same explanation for lobster-online-repost, lets not simply crash the tool and do nothing.
Suggestion: Crashing a tool if something goes wrong is not ok, any tool must recover from any kind of errors and never crash.
There was a problem hiding this comment.
Use case: same file into two different folders.
There was a problem hiding this comment.
I agree that a tool must never crash. But then please raise an exception instead of silently ignoring the error.
|
Signed-off-by: NicoletaCroitoru <quic_ncroitor@quicinc.com>
05cb159 to
f204069
Compare
| @@ -161,15 +161,15 @@ def main(): | |||
| tag = Tracing_Tag("cpp", function_uid) | |||
| loc = File_Reference(filename, line_nr) | |||
|
|
|||
| assert tag.key() not in db | |||
There was a problem hiding this comment.
I agree that a tool must never crash. But then please raise an exception instead of silently ignoring the error.
Fix assert