From 635e1c3304e2807f5457ba9b9e0cc97928a36e64 Mon Sep 17 00:00:00 2001 From: Justin Traglia Date: Thu, 28 Mar 2024 11:46:47 -0500 Subject: [PATCH 1/2] nit: remove unnecessary call to into_u256() for bn128 add --- crates/precompile/src/bn128.rs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/crates/precompile/src/bn128.rs b/crates/precompile/src/bn128.rs index c243e7e477..bb8e0d6292 100644 --- a/crates/precompile/src/bn128.rs +++ b/crates/precompile/src/bn128.rs @@ -141,16 +141,9 @@ pub fn run_add(input: &[u8]) -> Result { let mut output = [0u8; 64]; if let Some(sum) = AffineG1::from_jacobian(p1 + p2) { - sum.x() - .into_u256() - .to_big_endian(&mut output[..32]) - .unwrap(); - sum.y() - .into_u256() - .to_big_endian(&mut output[32..]) - .unwrap(); + sum.x().to_big_endian(&mut output[..32]).unwrap(); + sum.y().to_big_endian(&mut output[32..]).unwrap(); } - Ok(output.into()) } From 8b599c7f93b594fb8d2c407ae4a00ac3be400a9b Mon Sep 17 00:00:00 2001 From: Justin Traglia Date: Thu, 28 Mar 2024 11:50:51 -0500 Subject: [PATCH 2/2] Rename out to output --- crates/precompile/src/bn128.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/precompile/src/bn128.rs b/crates/precompile/src/bn128.rs index bb8e0d6292..6e620141f6 100644 --- a/crates/precompile/src/bn128.rs +++ b/crates/precompile/src/bn128.rs @@ -155,12 +155,12 @@ pub fn run_mul(input: &[u8]) -> Result { // `Fr::from_slice` can only fail when the length is not 32. let fr = bn::Fr::from_slice(&input[64..96]).unwrap(); - let mut out = [0u8; 64]; + let mut output = [0u8; 64]; if let Some(mul) = AffineG1::from_jacobian(p * fr) { - mul.x().to_big_endian(&mut out[..32]).unwrap(); - mul.y().to_big_endian(&mut out[32..]).unwrap(); + mul.x().to_big_endian(&mut output[..32]).unwrap(); + mul.y().to_big_endian(&mut output[32..]).unwrap(); } - Ok(out.into()) + Ok(output.into()) } pub fn run_pair(