Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce error type for EnvError #685

Closed
rakita opened this issue Sep 5, 2023 · 2 comments · Fixed by #731
Closed

Introduce error type for EnvError #685

rakita opened this issue Sep 5, 2023 · 2 comments · Fixed by #731
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Sep 5, 2023

https://github.com/bluealloy/revm/blob/c0767fa3e3b49497fa67cef37a9519fa6e55dd12/crates/primitives/src/result.rs#L127-L128C22

After eip4844 we would have two filed that should have been set if spec is Cancun. We can group them as a cleanup.

Do it after eip4844 PR is merged: #668
@rakita rakita mentioned this issue Sep 5, 2023
Merged
@rakita rakita added the good first issue Good for newcomers label Sep 18, 2023
@rakita rakita changed the title Introduce error type for wrong BlockEnv Introduce error type for EnvError Sep 18, 2023
@rakita rakita mentioned this issue Sep 18, 2023
Merged
@hack3r-0m
Copy link
Contributor

I would like to work on this, am i correct in understanding that EnvError will include PrevrandaoNotSet & ExcessBlobGasNotSet and would be would be variant of EVMError ?

@rakita
Copy link
Member Author

rakita commented Sep 19, 2023

I would like to work on this, am i correct in understanding that EnvError will include PrevrandaoNotSet & ExcessBlobGasNotSet and would be would be variant of EVMError ?

yep, small change, mostly ergonimics

@hack3r-0m hack3r-0m mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: error type for block header hack3r-0m/revm
2 participants
@rakita @hack3r-0m