Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align SiteHeader #43

Open
emilyjablonski opened this issue Sep 7, 2023 · 1 comment
Open

Align SiteHeader #43

emilyjablonski opened this issue Sep 7, 2023 · 1 comment

Comments

@emilyjablonski
Copy link

emilyjablonski commented Sep 7, 2023

Even though there’s a fair amount of changes to the SCSS file, they’re mostly around variables and I actually think it’s worth it in this case to see what the new variables are and pull them back to UIC where helpful.

Even though this component won’t exist in Seeds, when we move it to where it should live in core, it’s still helpful to have those variable overrides in a local component for forked consumers to customize if they have light changes without having to make a change to the SCSS file itself to stay in sync.

@sarahlazarich
Copy link
Collaborator

There are some variables changes, Emily already solved a lot of thus on link wrapping issue
Ideal case after this, DW will pull in UIC siteheader, but might need to pull more variables in to make that happen
Design confirmed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants