Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align SiteFooter #42

Open
emilyjablonski opened this issue Sep 7, 2023 · 1 comment
Open

Align SiteFooter #42

emilyjablonski opened this issue Sep 7, 2023 · 1 comment

Comments

@emilyjablonski
Copy link

emilyjablonski commented Sep 7, 2023

The customizations here made in the SCSS file are just to style the content within the footer itself, and don't have anything to do w the component itself.

I think ideally the content is handled entirely by the consumer outside of the component, and if we still want a component then the SiteFooter can be a styled container. For now, we could move this locally as just a component in Doorway public/partners while we have more conversations about what to do about these components in the pod squad.

@sarahlazarich
Copy link
Collaborator

DW has changed this so much, not sure if it should be a component
Emily j recommends that we just let this live in doorway instead of UIC as its own thing
Jesse clarified if this is an alignment ticket - align w FE conventions, not asking if there is design changes/fixes that should make

  • confirmed, this is an alignment ticket
  • No UIC changes, just move the file in to doorway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants