Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align NavigationContext #41

Open
emilyjablonski opened this issue Sep 7, 2023 · 2 comments
Open

Align NavigationContext #41

emilyjablonski opened this issue Sep 7, 2023 · 2 comments

Comments

@emilyjablonski
Copy link

emilyjablonski commented Sep 7, 2023

There is a new prop here that allows you to add a ref onto anchor tags. Without spending more time digging deep - I’m not sure why this was added and why the existing href wasn’t sufficient.

It looks to be like maybe this ref was added so that we could also navigate to the same URL from an anchor tag in a different onClick function in the same file - but if this proves to be the case I would recommend just navigating using the onClick vs creating a ref to call .click(), and then we don't need the ref change.

@slowbot
Copy link

slowbot commented Sep 12, 2023

@emilyjablonski Is this similar to the Seeds Menu component?

@emilyjablonski
Copy link
Author

@slowbot It's not, this is the "component" ala helper we use in UIC to allow consumers to override link behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants