Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align FieldGroup #34

Open
emilyjablonski opened this issue Sep 7, 2023 · 0 comments
Open

Align FieldGroup #34

emilyjablonski opened this issue Sep 7, 2023 · 0 comments

Comments

@emilyjablonski
Copy link

emilyjablonski commented Sep 7, 2023

There is an added SCSS file in Doorway for the FieldGroup that doesn't exist in UIC. It looks like it just styles the checkbox set on the homepage. We can move that to a style in a public overrides file.

There are some changes to the component itself that are a little funky.

There is a new prop that styles the field group to have a double column option, but I think we can accomplish this with the existing fieldClassName prop.

There are also new additions to local state keeping track of what checkboxes are currently checked - but at the same looks like it isn’t used anywhere, and this is data we can handle with react-hook-form. There might be more to it upon further investigation but I would recommend trying to remove all of that and testing the component on the public site with react-hook-form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant