Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas tracker behaviour in case of null gas prices from backend #1921

Closed
yvaskov opened this issue May 16, 2024 · 0 comments · Fixed by #1941
Closed

Gas tracker behaviour in case of null gas prices from backend #1921

yvaskov opened this issue May 16, 2024 · 0 comments · Fixed by #1941
Assignees
Labels
enhancement New feature or request v1.31.0 Release v1.31.0

Comments

@yvaskov
Copy link
Contributor

yvaskov commented May 16, 2024

Description

When backend returns null for all 3 gas values, we should:

  • Display a disclaimer on Gas tracker page
  • Hide gas tracker widget on homepage

This behaviour should occur only with 3 nulls:

"gas_prices": {
    "average": null,
    "fast": null,
    "slow": null
}

In case when backend returns an update with nulls (after providing valid values in the first place), N/A should be displayed instead.

Text for empty state:
"No data available yet"

@yvaskov yvaskov added the enhancement New feature or request label May 16, 2024
@tom2drum tom2drum mentioned this issue May 20, 2024
4 tasks
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.31.0 Release v1.31.0 and removed pre-release Tasks in pre-release right now labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.31.0 Release v1.31.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants