-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace improvements #1270
Comments
UPD 17.11: Regarding the first point: decided to use Safe SDK to connect a global wallet to a specific protocol. The example is available here: https://www.impersonator.xyz/ |
UPD 04.12: Need research on the Safe SDK and how we can use it for the end-to-end wallet connection in Blocksocut. Max needs help here |
UPD 04.12: @maxaleks when you finish everything, could you pls rename:
|
Testing instructions: The new functionality for wallet interaction via iframe works in dApps that have integrated Safe SDK. However, there are exceptions: if domain restrictions are set during the SDK initialization, our feature might not work. This has been particularly observed in applications using Blocknative's library. Testing should include:
|
What to do?
1️⃣ Add a wallet connect button to the header
We need to add the “Connect wallet” button to the header.
Expected behavior:
After the user connects the wallet:
If possible, we need to change the network inside the app automatically for the necessary one. For example, the user connected the wallet with the Polygon network but opened a dApp on the main net. In this case, we need to offer him to change the network to main net
IMPORTANT NOTICE:
Design: https://www.figma.com/file/4In0X8UADoZaTfZ34HaZ3K/Blockscout_2.0?type=design&node-id=444%3A1253&mode=design&t=0aa2uxJTzhCDpiHO-1
2️⃣ Add analytical event
We need to add the analytical event for tracking the global wallet connection
We already have the event
Wallet connect
, we just need to extend it with an additional parameterWhen a user connects a wallet globally on the header:
Event: Wallet connect
Parameters:
When a user connects a wallet on the smart contracts page:
Event: Wallet connect
Parameters:
3️⃣ Add the full-size mode
We need to support the full-size mode for dApps by default. It'll look like this:
IMPORTANT notices:
4️⃣ Add the disclaimer
We also need to show the disclaimer message for new users who first time interact with the marketplace. They will see the popup with the text just once before opening the app. For further dApps, a user won't see any popups. Only in the case, when he clicked on the "Continue to dApp" button
Disclaimer text:
"You are now accessing a third-party app. Blockscout does not own, control, maintain, or audit 3rd party apps, and is not liable for any losses associated with these interactions. Please do so at your own risk.
By clicking continue, you agree that you understand the risks and have read the Disclaimer."
Design: https://www.figma.com/file/6R0Rfb4nFodpxaq4krHrWT/Blockscout-Apps?type=design&node-id=3%3A3&mode=design&t=nk8n6niv6Xtp768U-1
5️⃣ Add messages for the profile and wallet buttons
We need to show a small message for the profile and connected wallet button
For profile:

"Sign in to My Account to add tags, create watchlists, access API keys, and more"
For the connect wallet button:

"Your wallet is used to interact with apps and contracts in the explorer"
IMPORTANT:
Design: https://www.figma.com/file/4In0X8UADoZaTfZ34HaZ3K/Blockscout_2.0?type=design&node-id=444%3A1253&mode=design&t=0aa2uxJTzhCDpiHO-1
The text was updated successfully, but these errors were encountered: