From e96e1b7c3fa57a98fd049ba57d4512d83dc5da29 Mon Sep 17 00:00:00 2001 From: Andrew Lee Rubinger Date: Thu, 12 Dec 2024 20:20:41 -0800 Subject: [PATCH 1/3] Issue #56 - Publish SNAPSHOTs to Maven Central, not TBD Artifactory --- .github/workflows/build.yml | 10 +++------- .maven_settings.xml | 20 -------------------- pom.xml | 17 ----------------- 3 files changed, 3 insertions(+), 44 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 88e70dd..bc1ab47 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -95,17 +95,13 @@ jobs: --batch-mode \ -DnewVersion=${{ steps.resolve_version.outputs.resolved_version }} - set +x - GITHUB_ID_TOKEN="$(curl -sLS -H "User-Agent: actions/oidc-client" -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" "${ACTIONS_ID_TOKEN_REQUEST_URL}&audience=jfrog-github" | jq -r .value)" - export ARTIFACTORY_PASSWORD="$(curl -fsH "Content-Type: application/json" "https://blockxyz.jfrog.io/access/api/v1/oidc/token" -d "{\"grant_type\": \"urn:ietf:params:oauth:grant-type:token-exchange\", \"subject_token_type\":\"urn:ietf:params:oauth:token-type:id_token\", \"subject_token\": \"${GITHUB_ID_TOKEN}\", \"provider_name\": \"github\"}" | jq -r .access_token)" - export ARTIFACTORY_USERNAME="github/${GITHUB_ACTOR}" - set -x - # Maven deploy lifecycle will build, run tests, verify, sign, and deploy - mvn deploy --batch-mode --settings .maven_settings.xml -P sign-artifacts + mvn deploy --batch-mode --settings .maven_settings.xml -P sign-artifacts,ossrh env: SIGN_KEY_PASS: ${{ secrets.GPG_SECRET_PASSPHRASE }} SIGN_KEY: ${{ secrets.GPG_SECRET_KEY }} + SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} + SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v5 diff --git a/.maven_settings.xml b/.maven_settings.xml index b15e703..10a5682 100644 --- a/.maven_settings.xml +++ b/.maven_settings.xml @@ -1,25 +1,5 @@ - - block-oss-releases - ${env.ARTIFACTORY_USERNAME} - ${env.ARTIFACTORY_PASSWORD} - - - block-oss-snapshots - ${env.ARTIFACTORY_USERNAME} - ${env.ARTIFACTORY_PASSWORD} - - - block-oss-releases - ${env.ARTIFACTORY_USERNAME} - ${env.ARTIFACTORY_PASSWORD} - - - block-oss-snapshots - ${env.ARTIFACTORY_USERNAME} - ${env.ARTIFACTORY_PASSWORD} - ossrh-snapshots ${env.SONATYPE_USERNAME} diff --git a/pom.xml b/pom.xml index 9d6bbb4..7736d30 100644 --- a/pom.xml +++ b/pom.xml @@ -460,23 +460,6 @@ - - - false - block-oss-releases - Block OSS Releases Repository - https://blockxyz.jfrog.io/artifactory/block-oss-releases-maven2 - default - - - false - block-oss-snapshots - Block OSS Snapshots Repository - https://blockxyz.jfrog.io/artifactory/block-oss-snapshots-maven2 - default - - - block-oss-thirdparty From 4560f5d5638eea33e6e9f4aa3730f12ef765abc7 Mon Sep 17 00:00:00 2001 From: Andrew Lee Rubinger Date: Thu, 12 Dec 2024 20:25:55 -0800 Subject: [PATCH 2/3] Issue #56 - Update to new org secret name --- .github/workflows/build.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bc1ab47..da09cf0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -100,8 +100,8 @@ jobs: env: SIGN_KEY_PASS: ${{ secrets.GPG_SECRET_PASSPHRASE }} SIGN_KEY: ${{ secrets.GPG_SECRET_KEY }} - SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} - SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} + SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME_XYZ_BLOCK }} + SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD_XYZ_BLOCK }} - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v5 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8d8948f..248af41 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -75,8 +75,8 @@ jobs: env: SIGN_KEY_PASS: ${{ secrets.GPG_SECRET_PASSPHRASE }} SIGN_KEY: ${{ secrets.GPG_SECRET_KEY }} - SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} - SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} + SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME_XYZ_BLOCK }} + SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD_XYZ_BLOCK }} - name: Create GitHub Release uses: softprops/action-gh-release@v2 From eac8f67afe6fc592b282389c55e0d033dd15c206 Mon Sep 17 00:00:00 2001 From: finn Date: Fri, 13 Dec 2024 10:40:50 -0800 Subject: [PATCH 3/3] publishing: add tailing slash to ossrh-snapshots URL Align with URLs from https://central.sonatype.org/publish/publish-guide/#accessing-repositories --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7736d30..e3ab02f 100644 --- a/pom.xml +++ b/pom.xml @@ -449,7 +449,7 @@ ossrh-snapshots - https://s01.oss.sonatype.org/content/repositories/snapshots + https://s01.oss.sonatype.org/content/repositories/snapshots/