perp positions changes #63
Conversation
proto/api.proto
Outdated
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "Returns the list current perp positions"; | ||
| summary: "PERP positions"; | ||
| tags: ["Trade", "Universal"]; |
There was a problem hiding this comment.
Think this should be Orderbook, not Universal? Also, probably worth adding a "Perp" tag too
There was a problem hiding this comment.
added "Perp", "Orderbook" tags
proto/api.proto
Outdated
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "closes current perp positions"; | ||
| summary: "PERP positions"; | ||
| tags: ["Trade", "Universal"]; |
There was a problem hiding this comment.
added "Perp", "Orderbook" tags
proto/api.proto
Outdated
| repeated string transactions = 1; | ||
| } | ||
|
|
||
| message GetCurrentPerpPosition { |
There was a problem hiding this comment.
I think also get rid of the Get in front of the name. This doesn't have to just be part of a Get requests and is a more general datatype
proto/api.proto
Outdated
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "post a perp order"; | ||
| summary: "perp order"; | ||
| tags: ["Trade", "Orderbook"]; |
proto/api.proto
Outdated
|
|
||
| rpc GetPerpPositions(GetPerpPositionsRequest) returns (GetPerpPositionsResponse) { | ||
| option (google.api.http) = { | ||
| get: "/api/v1/trade/perp-positions" |
proto/api.proto
Outdated
|
|
||
| rpc PostClosePerpPositions(PostClosePerpPositionsRequest) returns (PostClosePerpPositionsResponse) { | ||
| option (google.api.http) = { | ||
| get: "/api/v1/trade/close-perp-positions" |
proto/api.proto
Outdated
| repeated string transactions = 1; | ||
| } | ||
|
|
||
| message GetCurrentPerpPosition { |
There was a problem hiding this comment.
I think also get rid of the Get in front of the name. This doesn't have to just be part of a Get requests and is a more general datatype
proto/api.proto
Outdated
| Project project = 1; | ||
| string ownerAddress = 2; | ||
| string accountAddress = 3; | ||
| repeated common.PerpContract contracts = 4; | ||
| } | ||
|
|
||
| message GetPerpPositionsResponse { | ||
| message PerpPositionsResponse { |
There was a problem hiding this comment.
think you misunderstood my comment here. These messages should have the Get in front of it. GetPerpPosition (field #3 here) is the one that shouldn't
There was a problem hiding this comment.
the messages that match the RPC method (e.g. GetPerpPositions(PerpPositionsRequest) returns (PerpPositionsResponse)) should always have the Get prefix. It's jsut the data types within the Request/Response objects that should not
There was a problem hiding this comment.
fixed this
No description provided.