Adding isCleanUp to Transaction

[tinystarinagalaxy]

No description provided.

[aspin]

@DimaCantemir suggestion:

message TransactionMessage {
    string content = 1;
    bool isCleanup = 2;
}

[tinystarinagalaxy]

done

[aspin]

thoughts on if you want to make this universal, including endpoints that only return a single transaction? I'm a little mixed on the consistency of all endpoints vs. teh useless data fields

[tinystarinagalaxy]

thoughts on if you want to make this universal, including endpoints that only return a single transaction? I'm a little mixed on the consistency of all endpoints vs. the useless data fields

what specific endpoint you have in mind? I checked all other endpoints. they look clean to me so far. there is some validity with the consistency point that you are raising.

if it looks awkwardly inconsistent, we can apply the same change later as well. it's a minor change.

[aspin]

thoughts on if you want to make this universal, including endpoints that only return a single transaction? I'm a little mixed on the consistency of all endpoints vs. the useless data fields

what specific endpoint you have in mind? I checked all other endpoints. they look clean to me so far. there is some validity with the consistency point that you are raising.

if it looks awkwardly inconsistent, we can apply the same change later as well. it's a minor change.

I was thinking all of them, for example

message PostOrderResponse {
  string transaction = 1;
  string openOrdersAddress = 2;
}

I'm leaning a bit more to consistency of fields vs. the unnecessary ones, but could be swayed either way. any thoughts @DimaCantemir @kdonthi @atulsriv @yobloxroute ?

[atulsriv]

thoughts on if you want to make this universal, including endpoints that only return a single transaction? I'm a little mixed on the consistency of all endpoints vs. the useless data fields

what specific endpoint you have in mind? I checked all other endpoints. they look clean to me so far. there is some validity with the consistency point that you are raising.
if it looks awkwardly inconsistent, we can apply the same change later as well. it's a minor change.

I was thinking all of them, for example

message PostOrderResponse {
  string transaction = 1;
  string openOrdersAddress = 2;
}

I'm leaning a bit more to consistency of fields vs. the unnecessary ones, but could be swayed either way. any thoughts @DimaCantemir @kdonthi @atulsriv @yobloxroute ?

I think consistency of fields looks a bit cleaner. Not sure how much it really matters vs. keeping the unnecessary fields, but it looks better imo.

[tinystarinagalaxy]

PostOrderResponse

hmm, that would be a bigger change, let's create a ticket for it, if we decide to go for all.

[tinystarinagalaxy]

PostOrderResponse

hmm, that would be a bigger change, let's create a ticket for it, if we decide to go for all.

i merge this for now