postsubmit-batch endpoint #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspin
approved these changes
Oct 14, 2022
proto/api.proto
Outdated
| @@ -660,10 +672,35 @@ message PostSubmitRequest { | |||
| bool skipPreFlight = 2; | |||
| } | |||
|
|
|||
| message PostSubmitBatchRequestEntry { | |||
There was a problem hiding this comment.
Maybe just reuse PostSubmiRequest instead of creating this struct?
| message PostSubmitResponse { | ||
| string signature = 1; | ||
| } | ||
|
|
||
| message PostSubmitBatchResponseEntry { | ||
| string signature = 1; | ||
| string error = 2; |
There was a problem hiding this comment.
perhaps also a boolean that indicates if it's submitted or not? could encapsulate that in error as well –– wdyt?
There was a problem hiding this comment.
i think a boolean is a better idea. makes the client to figure out if it was submitted instantly rather checking error messages for something that is not an error
aspin
approved these changes
Oct 19, 2022
d9cdc9c to
cfcd30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.