TRAD-210 swap with route specification #24
Conversation
proto/api.proto
Outdated
| @@ -288,6 +288,17 @@ service Api { | |||
| }; | |||
| } | |||
|
|
|||
| rpc PostMultiRouteTradeSwap(MultiRouteTradeSwapRequest) returns (MultiRouteTradeSwapResponse) { | |||
There was a problem hiding this comment.
naming: I don't think Multi should be part of this name. This is a swap with a route specification, and it's valid if the user decides to give a route specification of size 1. So I think PostRouteTradeSwap or PostRouteSwap would be better
proto/api.proto
Outdated
| string outToken = 4; | ||
| double inAmount = 5; | ||
| double slippage = 6; | ||
| string middleToken = 4; |
There was a problem hiding this comment.
does middle token need to be made to the original request?
There was a problem hiding this comment.
no, removed it
dd8a398 to
b4c25a4
Compare
proto/api.proto
Outdated
| @@ -289,6 +289,17 @@ service Api { | |||
| }; | |||
| } | |||
|
|
|||
| rpc PostRouteTradeSwap(RouteTradeSwapRequest) returns (RouteTradeSwapResponse) { | |||
| option(google.api.http) = { | |||
| get: "/api/v1/amm/route-trade-swap" | |||
There was a problem hiding this comment.
endpoint needs to be updated: should be /api/v1/trade/route-swap
proto/api.proto
Outdated
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "routes swap(s) from supported amms"; | ||
| summary: "Routes swaps"; | ||
| tags: "AMMs"; |
proto/api.proto
Outdated
| get: "/api/v1/amm/route-trade-swap" | ||
| }; | ||
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "routes swap(s) from supported amms"; |
There was a problem hiding this comment.
description for consistency: "Generates an unsigned transaction object for the AMM swap on the specified route"
summary for consistency: "Unsigned AMM swap transaction along route"
b4c25a4 to
2cf0e78
Compare
proto/api.proto
Outdated
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = { | ||
| description: "Generates an unsigned transaction object for the AMM swap on the specified route"; | ||
| summary: "Unsigned AMM swap transaction along route"; | ||
| tags: "Trade/AMM"; |
There was a problem hiding this comment.
actually should be ["Trade", "AMM"] now, after some review changes on my end
proto/api.proto
Outdated
| @@ -311,6 +311,17 @@ service Api { | |||
| }; | |||
| } | |||
|
|
|||
| rpc PostRouteTradeSwap(RouteTradeSwapRequest) returns (RouteTradeSwapResponse) { | |||
| option(google.api.http) = { | |||
| get: "/api/v1/amm/route-swap" | |||
There was a problem hiding this comment.
endpoint needs to be /api/v1/trade/route-swap
|
bump on the tags comment |
No description provided.