TRAD-211 Added support for QetQuotesStream #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdonthi
reviewed
Sep 19, 2022
| string token1Address = 3; | ||
| string token2 = 4; | ||
| string token2Address = 5; | ||
| double token1ToToken2 = 6; |
There was a problem hiding this comment.
Shouldn't we give the paths? Or are we only doing direct routes?
There was a problem hiding this comment.
since these quotes are calculated on the fly based on the account changes that hold information relevant to reserves of a specific pool - it's always one pool... and we provide the quote for both way swaps. Should be enough for now, as a usability test. If the customers like it an need changes we'll accommodate
kdonthi
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRAD-211 Added support for QetQuotesStream