Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making transactions repeated in TradeSwapResponse #13

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

tinystarinagalaxy
Copy link
Contributor

No description provided.

@@ -717,7 +717,7 @@ message TradeSwapRequest{

message TradeSwapResponse{
Project project = 1;
string transaction = 2;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

because a routeswap transaction has two separate transactions possibly. a setup and a swap one.

The setup transaction is used for creating associated token accounts in case a user don't have those.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not possible to do both operations in the same transaction? I've seen logic on Jupiter to do the same (setup/teardown instructions), but it's not really clear to me why we can't just have one large transaction

@tinystarinagalaxy tinystarinagalaxy changed the title making transactions repeated Making transactions repeated in TradeSwapResponse Sep 15, 2022
@@ -717,7 +717,7 @@ message TradeSwapRequest{

message TradeSwapResponse{
Project project = 1;
string transaction = 2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not possible to do both operations in the same transaction? I've seen logic on Jupiter to do the same (setup/teardown instructions), but it's not really clear to me why we can't just have one large transaction

@tinystarinagalaxy tinystarinagalaxy merged commit 71069aa into develop Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants