Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Build does not fail when branch coverage is less than 100% #444

Closed
Blackbaud-PaulCrowder opened this issue Apr 4, 2016 · 4 comments
Closed

Comments

@Blackbaud-PaulCrowder
Copy link
Member

Expected behavior

The Travis CI build should fail if the unit test code coverage stats for statements, branches, functions and lines are not all 100%

Actual behavior

The Travis CI build should succeeds if the unit test code coverage stats for statements is 100% but branches is less than 100%

Steps to reproduce

Get latest from master and run grunt build test. Open the index.html file in the coverage/ folder and notice that both autonumeric/ and error/ have branch coverage of less than 100%.

@Blackbaud-PaulCrowder
Copy link
Member Author

lemurheavy/coveralls-public#31

One commenter mentioned switching to codecov.io.

@Blackbaud-BobbyEarl
Copy link

Testing implementation with Codecov via #454 worked well.

Current code coverage is lower than expected as they don't support "optional documentation" in Istanbul comments. https://github.com/codecov/support/issues/151

@Blackbaud-PatrickOFriel
Copy link
Contributor

If this doesnt get address by codecov by May 16, we'll change our comments to fit their requirements

@Blackbaud-PatrickOFriel
Copy link
Contributor

Changed our code coverage comments, waiting on codecov to release a fix which will respect /*istanbul ignore next */ with functions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants